Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version attribute in SCIM Metadata response does not follow RFC #822

Open
nwoolls opened this issue Dec 3, 2024 · 1 comment
Open

Version attribute in SCIM Metadata response does not follow RFC #822

nwoolls opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nwoolls
Copy link
Contributor

nwoolls commented Dec 3, 2024

Currently, the version attribute returned by the SCIM server in the meta section of a resource is a number. The RFC for SCIM 2 indicates this should be an ETag. Most implementations I've worked with (and indeed all of the RFC examples) have this attribute as a string, so our parsing logic falls down when this SCIM server returns a number.

See: https://datatracker.ietf.org/doc/html/rfc7643#section-3.1

@simpleidserver simpleidserver self-assigned this Dec 3, 2024
@simpleidserver simpleidserver moved this to In Progress in Release 5.0.3 Dec 3, 2024
@simpleidserver simpleidserver added the bug Something isn't working label Dec 4, 2024
thabart added a commit that referenced this issue Dec 4, 2024
@simpleidserver
Copy link
Owner

Hello,

The issue has been fixed in the Release503 branch.
The version property of a representation is now returned as a string.

By default, the version is an integer that increments each time a modification is made to the representation. However, you can define your own versioning logic by implementing the following interface:

public interface IRepresentationVersionBuilder
{
    string Build(SCIMRepresentation representation);
}

public class CustomRepresentationVersionBuilder : IRepresentationVersionBuilder
{
    public string Build(SCIMRepresentation representation)
    {
        return Guid.NewGuid().ToString()
    }
}

Changes : 8a3345f

KR,

SID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants