Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Press the '#' button near the password field or use Ctrl+# to hash the password in place" not working #30

Open
HerrBert233 opened this issue Jul 31, 2020 · 2 comments

Comments

@HerrBert233
Copy link

HerrBert233 commented Jul 31, 2020

  • There is no '#' button near the password field
  • Ctrl+# has no effect

Firefox 79 x64, Windows 10, all websites

@simu
Copy link
Owner

simu commented Aug 17, 2020

The '#' button near the password field was removed a couple releases ago, when I changed the extension to use a page action instead of a browser action, as there was no way to open the page action dialog from JavaScript.

The keyboard shortcut for the page action is configured in the extension manifest:

"commands": {
"_execute_page_action": {
"suggested_key": { "default": "Ctrl+Shift+3" }
}
},
The shortcut defaults to Ctrl+Shift+3 which maps to '#' on the en_US keyboard layout. You can adjust the shortcut by going to about:addons, clicking the cogwheel and selecting "Manage Extension Shortcuts".

I will update the documentation to include this information for the next release.

@LiPeK
Copy link

LiPeK commented Aug 17, 2020

It seems that this shortcut conflicts with "Firefox Multi-Account Containers" add-on. If someone uses it, I suggest to set the "Container to open with Keyboard Shortcut 3" to "None" in that add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants