Made the DevTools to detect for mobile mode #46
Conversation
|
Can you please explain your changes? |
|
You also need to ensure the linting passes. |
|
@sindresorhus do you mean I have to edit the code to pass the check. |
As for the changes since when opening in responsive mode(for phones/tablets and even in higher screen sizes) the inner and outer width or inner height remains the same even wen developer console Is open. So I just wrote a function to check if the user agent is a phone and created another function to execute console.log and get the performance difference before and after it finish to execute console.log and the value will vary depending on whether developers console is open or not. And I used this value to determine whether if the console is open or not. |
Co-authored-by: Pedro Augusto de Paula Barbosa <[email protected]>
| // Check how long its takes for the given code to execute | ||
| // It return a value after execution | ||
| // If value is greater than 60 then dev tool is open | ||
| // If value is less than 60 then dev tool is not open |
There was a problem hiding this comment.
This sounds very fragile. Is this really reliable enough? The performance difference between devices can be huge. For example, maybe the new M1 Macbook's manage to do this in less than 60 even when DevTools is open.
| !(heightThreshold && widthThreshold) && | ||
| ((window.Firebug && window.Firebug.chrome && window.Firebug.chrome.isInitialized) || widthThreshold || heightThreshold) | ||
| ) { | ||
| if (!(heightThreshold && widthThreshold) && ((window.Firebug && window.Firebug.chrome && window.Firebug.chrome.isInitialized) || widthThreshold || heightThreshold)) { |
There was a problem hiding this comment.
Don't do unrelated changes.
| } | ||
|
|
||
| devtools.isOpen = true; | ||
| devtools.orientation = ''; |
| if ((!devtools.isOpen || devtools.orientation !== orientation) && emitEvents) { | ||
| emitEvent(true, orientation); | ||
| } | ||
|
|
||
| devtools.isOpen = true; | ||
| devtools.orientation = orientation; | ||
| } else if (isPhone()) { | ||
| if (parseInt(checkPerformance(), 0) > 60) { |
Made to detect when dev tools is opened in mobiles mode and table/ipad
Fixes #35
For iphone
For Android
Browser used: Firefox
IssueHunt Summary
Referenced issues
This pull request has been submitted to: