Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AbortController #116

Open
kbrgl opened this issue Feb 23, 2024 · 2 comments · May be fixed by #121
Open

Support AbortController #116

kbrgl opened this issue Feb 23, 2024 · 2 comments · May be fixed by #121
Labels
enhancement help wanted

Comments

@kbrgl
Copy link

kbrgl commented Feb 23, 2024 •
edited
Loading

It would be awesome if it was possible to pass an AbortController to Emittery as part of the options for on(), the same way addEventListener allows. This would make complex listener removal scenarios much easier to work with, such as removing all event listeners when a specific event listener fires.
@ylc395
Copy link

ylc395 commented Nov 16, 2024

This feature will be very useful. If it's acceptable, I can submit a PR @sindresorhus

@JiveOff
Copy link

JiveOff commented Nov 26, 2024

This would be extra useful indeed.

@ylc395 ylc395 linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support abort signal ylc395/emittery
4 participants
@sindresorhus @ylc395 @kbrgl @JiveOff