Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous maglev function #27

Open
ed1d1a8d opened this issue Sep 6, 2017 · 1 comment
Open

Extraneous maglev function #27

ed1d1a8d opened this issue Sep 6, 2017 · 1 comment
Assignees

Comments

@ed1d1a8d
Copy link
Contributor

ed1d1a8d commented Sep 6, 2017

I propose that we get rid of the function Add:
https://github.com/sipb/spike/blob/master/maglev/maglev.go#L109-L111

I think it complicates the api. I feel things would be simpler if only SetWeight were used.

@cryslith
Copy link
Member

cryslith commented Sep 7, 2017

@ed1d1a8d Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants