You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been confused because the generation process had succeeded but the files had been not created.
Your Environment
Version used: 8.0.0
Operating System and versions: macOS 14.0 (23A344)
Link to your project: N/A
The text was updated successfully, but these errors were encountered:
tnyo43
changed the title
want a process to fail when some generations fail
feature request: a process to fail when some generations fail
Apr 8, 2024
tnyo43
changed the title
feature request: a process to fail when some generations fail
feature request: whole process to fail when some process fails
Apr 8, 2024
Your issue may already be reported!
Please search on the issue tracker before creating one. <- DONE
Expected Behavior
If generation processes for invalid scss files fail, I want the entire process to fail as well.
Current Behavior
Error messages for invalid scss files are displayed, but the entire process finishes successfully.
Possible Solution
I think this behavior is come from the code below.
typed-scss-modules/lib/core/write-file.ts
Lines 71 to 75 in 546dba6
When an error is thrown, it catches but not throw another error again.
We may be able to just re-throw the error. However, I read this comment and am thinking we need some tricks... 🤔
typed-scss-modules/lib/core/generate.ts
Lines 28 to 29 in 546dba6
Steps to Reproduce (for bugs)
reproduction
npm install
npm run generate
You will see some thing like below but the whole process succeeded:
Context
I've been confused because the generation process had succeeded but the files had been not created.
Your Environment
The text was updated successfully, but these errors were encountered: