Split spec files to examples programmatically #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
force-pushed
the
gh6-split-files-programmatically
branch
2 times, most recently
from
f0b71dc to
2f9ceb5
Compare
fragoulis
approved these changes
Sep 24, 2020
| JSON.parse(out.string)["examples"].map { |e| e["id"] } | ||
| ensure | ||
| RSpec.configuration.dry_run = dry_run_before | ||
| reset_rspec_state! |
There was a problem hiding this comment.
Explain, why do you need to set the original value for the dry_run (only)?
There was a problem hiding this comment.
Because that's the one we're messing with (we set it to true so that we can fetch the example ids without executing any tests). On the contrary, configuration.files_or_directories_to_run and the formatter we add, are things that will get taken care of by reset_rspec_state!.
Improves testability.
agis
force-pushed
the
gh6-split-files-programmatically
branch
from
2f9ceb5 to
a9c4490
Compare
Instead of shelling out to rspec, we now split spec files into individual examples programmatically, using the RSpec Core API. This is faster and more robust, since we avoid common shell shenanigans. Closes #6
agis
force-pushed
the
gh6-split-files-programmatically
branch
from
a9c4490 to
1044904
Compare
|
This causes some failures on our internal builds. Will investigate and do a follow up. Closing it until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of shelling out to rspec, we now split spec files into individual examples programmatically, using the RSpec Core API. This is faster and more robust, since we avoid common shell shenanigans.
Closes #6