[ENH] should set_config
and get_config
be able to address deep
configs?
#282
Labels
set_config
and get_config
be able to address deep
configs?
#282
here's a question: should there be a
deep
arg toget_config
, likeget_params
? That way, we could avoid changes to_clone
, as then we just need to add thedeep
arg inclone
, once. It would be "cleaner" imo since it completely decouples the param logic from the config logic (coupling/cohesion improvement).That is, should
get_config
,set_config
of the top node object support getting/setting of component node configs - likeget_params
,set_params
- or do you have to address the components directly.I.e., compare
Both ways are already making the assumption that
clone
should keep configs across all nodes.Originally posted by @fkiraly in #276 (comment), moved here for discussion.
The text was updated successfully, but these errors were encountered: