Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gocyclo errors #1905

Open
mrpalide opened this issue Nov 10, 2024 · 1 comment
Open

Fix gocyclo errors #1905

mrpalide opened this issue Nov 10, 2024 · 1 comment
Labels
clean code some cleaning on codebase needs low priority We don't need to look into this now.

Comments

@mrpalide
Copy link
Contributor

mrpalide commented Nov 10, 2024

After fixing ticket #1865 and adding gocyclo to formatting process in CI (and local), we get about 14 errors there!
So we just ignore them for now, but should solve them.
Those ignored errors could be founding by TODO: fix gocyclo error. or gocyclo:ignore, e.g. :

// TODO: fix gocyclo error.
//
//gocyclo:ignore
func makeTree() {
@mrpalide mrpalide added low priority We don't need to look into this now. clean code some cleaning on codebase needs labels Nov 10, 2024
@0pcom
Copy link
Collaborator

0pcom commented Nov 14, 2024

The worst gocyclo errors are I believe caused by the actual reward system UI - i think..

I'm planning to re-do it eventually, to resolve those errors. It's safe to ignore any gocyclo errors related to the reward system UI for now because it's not core functionality that users have to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean code some cleaning on codebase needs low priority We don't need to look into this now.
Projects
None yet
Development

No branches or pull requests

2 participants