Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to F-Droid #19

Open
airon90 opened this issue Nov 23, 2020 · 17 comments
Open

Add to F-Droid #19

airon90 opened this issue Nov 23, 2020 · 17 comments

Comments

@airon90
Copy link

airon90 commented Nov 23, 2020

Hey, I noticed that this app is licensed by a free license and I'd like to see this app in the F-Droid cataolgue, a store of FOSS Android apps. Take a look to the request here

@airon90
Copy link
Author

airon90 commented Sep 19, 2021

@skydoves could you please fix this?

@skydoves
Copy link
Owner

Hey @airon90, Sorry for the late reply.
As following the comments, F-Droid can't recognize metadata that is located in the dependencies.gradle file right?
Then should I modify all of the references of the dependencies.gradle to statically or can we deal with it just by modifying the versionCode and versionName?

@IzzySoft
Copy link

F-Droid maintainer here. Thanks for chiming in, @skydoves! We'd need metadata (app description, summary, screenshots etc) in a Fastlane structure – and versionCode plus versionName as literals (not variables or function calls) in build.gradle (which is also important to automatically detect new versions).

@skydoves
Copy link
Owner

skydoves commented Sep 20, 2021

Hi @IzzySoft, thanks for the review. I just created a PR (#44) for integrating into the F-Droid, so could you please check the structure of the metadata is correct?

@IzzySoft
Copy link

versionName getVersionName()

won't work. versionName and versionCode (already is) must be literals – no variables or function calls, see above. Else updates won't be found (the F-Droid updater just uses RegEx to parse the gradle files, it doesn't execute them) and you'd need to create a merge request at fdroiddata vor each version, which is not a good idea 😉

Fastlane structure looks good – but short_description.txt is too long. It will be truncated at 80 chars.

You might wish to place an icon.png into metadata/en-US/images (not mandatory, but helpful – especially in case your app uses only XML icons).

@skydoves
Copy link
Owner

Hi @yehezkiell,
I updated the metadata from your reviews! Could you please check about it again?

@souvikpal2000
Copy link

Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?

@AndroidPoet
Copy link

AndroidPoet commented Feb 1, 2022

Can anybody can tell me how you all have calculated the stats of pokemon. Can anybody can share the formula?

Here is link for for that :https://github.com/skydoves/Pokedex/blob/main/app/src/main/java/com/skydoves/pokedex/model/PokemonInfo.kt
Also always create new issue or add a commnet in related open issue

@airon90
Copy link
Author

airon90 commented Feb 2, 2022

What about the issue? @skydoves @IzzySoft

@IzzySoft
Copy link

IzzySoft commented Feb 3, 2022

Sorry @airon90 – I'm usually not working in the "games segment". I've just carried over the issues I saw reported at F-Droid so they can be addressed. The request there will be worked on by another team member.

@inson1
Copy link

inson1 commented Oct 14, 2023

@skydoves Do you have updates?

@IzzySoft
Copy link

@inson1 see my comment just before yours: I don't work on games, so no need to ping me for updates on their progress 😉

@inson1
Copy link

inson1 commented Dec 19, 2023

@IzzySoft sorry :)

@IzzySoft
Copy link

Huh? Eh, err… Sorry, too // as it wasn't you 🙈

(I simply unsubscribe from notifications here then 😉)

@linsui
Copy link

linsui commented Sep 7, 2024

@skydoves Hi, could you please reopen and merge #44? Then I can help package Pokedex for F-Droid.

@skydoves
Copy link
Owner

skydoves commented Sep 7, 2024

Hey @linsui, thank you so much for your support. I just re-opened that PR.

@linsui
Copy link

linsui commented Sep 7, 2024

The PR is outdated. The static version part is not required now since we can get the version name from the tag and the version code is already there. Only the metadata part is needed. The filename of the changelog needs to match the version code, i.e., it should be 10.txt. Can you update it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants