-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Is this a dead library? #607
Comments
@felixchan looking for good alternatives |
@dzenbot Could you please give us a statement on the status of the SlackTextViewController? Do you intend to keep it alive and updated or should we look for alternatives? |
Agreed with @dzenbot need to know what to expect. But it looks dead to me... |
+1 It'd be very helpful to know the plans for this lib. This is a great library – but lacking maintenance is scary. Have folks here looked into alternatives? I love this lib's simplicity and flexibility – most solutions I have run into are overly complex and do too many things. Pointers are very helpful! |
@johndoehelloworld @yarodevuci MessageKit is making rapid progress on a Swift re-write of JSQMessagesViewController. But it is unclear to me how close they will come to the breadth of features in SlackViewController. |
We apologize for not being active lately on fixing/helping folks with this library. We are going to spend time addressing iOS 11 bug fixes real soon, as well as other small polishing. Any help is very welcomed too! |
Yessss thank you! <3 |
@dzenbot Would it be possible to issue a version bump for this library? The last release is close to a year ago and there are several changes I'd like to incorporate. |
+1 any plans to push a release for iOS 11 support? |
There is a list of open issues on iOS 11 https://github.com/slackhq/SlackTextViewController/issues?q=is%3Aissue+is%3Aopen+label%3A%22iOS+11%22 |
Any ETA on an update @dzenbot ? |
See my comment above. If you are using Cocoapods or Carthage, you can checkout to a specific commit or branch. You don’t need a release to be able to update anyway. |
Hi Ignacio, we are experiencing the same issue on iOS11, "Inserting/Deleting cells on iOS 11 causes tableView subviews to be unresponsive" issue #623. |
@dzenbot is this true? The Slack app for example supports the panning gesture nicely to close the keyboard. When I clone the repository here and run the examples, this feature does not seem to be working correctly. Would be great to clarify this question. I believe it's important for the community to know. |
That feature is native since iOS 8 or 9 if I recall. You need to set the ‘keyboardDismissMode’ property on a scroll view instance.
Jonathan Bouaziz
…________________________________
From: Johannes Plunien <[email protected]>
Sent: Tuesday, October 24, 2017 6:21:03 AM
To: slackhq/SlackTextViewController
Cc: Jonathan Bouaziz; Manual
Subject: Re: [slackhq/SlackTextViewController] Is this a dead library? (#607)
It seems that the iOS Slack app has moved on to a custom solution
@dzenbot<https://github.com/dzenbot> is this true? The Slack app for example supports the panning gesture nicely to close the keyboard. When I clone the repository here and run the examples, this feature does not seem to be working correctly. Would be great to clarify this question. I believe it's important for the community to know.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#607 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC3pXPLDuqZzLeM1PoyJIQY1YBdhCL4pks5svWWvgaJpZM4ONh0l>.
|
I know, but it doesn't change the fact that it's not working with SlackTextViewController. Just add this to Result looks like this (iPhone 5s, 10.3.1 Simulator): |
Although there are still known iOS 11 / iPhone X issues, I've pushed 1.9.6 release, which is also available on Cocoapods. At least, we've fixed the most critical issues. Thanks again to all the contributors! 👏 |
@dzenbot it still seems the setting |
@beamercola Please read the docs on that property. It is disabled, on purpose. It no longer works on newer iOS versions. |
@dzenbot, I think these statements should be front and center on the README - a large part of the attraction of using something like this is the backing/usage of the owner of the library. There are many of us who have used open source "magic" libraries which have (through normal software lifetimes) become "abandoned" (see https://github.com/jessesquires/JSQMessagesViewController). It's helpful to know straight out that something is going to be "...transitioned from..." by the original author(s). |
Working maintained fork: https://github.com/GitHawkApp/MessageViewController |
@beamercola MessageViewController is not a fork, and it's not feature compatible. I have hopes, but the author has stated "I don’t plan on adding any messaging functionality to this project". At the moment, it is predominantly an autocomplete control (the @, #, / behavior of SlackTextViewController) I don't know yet what he considers "messaging functionality" but to be a decent replacement for STVC I think it will at least need to have a baseline implementation of an autohiding input bar with support for buttons/toolbar/attachments and a typing indicator. |
It seems that the iOS Slack app has moved on to a custom solution, and no commits since March.
The text was updated successfully, but these errors were encountered: