Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Is this a dead library? #607

Open
felixchan opened this issue Jul 4, 2017 · 23 comments
Open

Is this a dead library? #607

felixchan opened this issue Jul 4, 2017 · 23 comments

Comments

@felixchan
Copy link

It seems that the iOS Slack app has moved on to a custom solution, and no commits since March.

@yarodevuci
Copy link

@felixchan looking for good alternatives

@luzianscherrer
Copy link

@dzenbot Could you please give us a statement on the status of the SlackTextViewController? Do you intend to keep it alive and updated or should we look for alternatives?

@yarodevuci
Copy link

Agreed with @dzenbot need to know what to expect. But it looks dead to me...

@johndoehelloworld
Copy link

johndoehelloworld commented Aug 16, 2017

+1 It'd be very helpful to know the plans for this lib. This is a great library – but lacking maintenance is scary. Have folks here looked into alternatives? I love this lib's simplicity and flexibility – most solutions I have run into are overly complex and do too many things. Pointers are very helpful!

@eliburke
Copy link

@johndoehelloworld @yarodevuci MessageKit is making rapid progress on a Swift re-write of JSQMessagesViewController. But it is unclear to me how close they will come to the breadth of features in SlackViewController.

@dzenbot
Copy link

dzenbot commented Sep 21, 2017

We apologize for not being active lately on fixing/helping folks with this library. We are going to spend time addressing iOS 11 bug fixes real soon, as well as other small polishing. Any help is very welcomed too!

@hipwelljo
Copy link
Contributor

Yessss thank you! <3

@andrewcl
Copy link

@dzenbot Would it be possible to issue a version bump for this library? The last release is close to a year ago and there are several changes I'd like to incorporate.

@evictor
Copy link

evictor commented Sep 29, 2017

+1 any plans to push a release for iOS 11 support?

@felixchan
Copy link
Author

@wsb9

@dzenbot
Copy link

dzenbot commented Sep 29, 2017

There is a list of open issues on iOS 11 https://github.com/slackhq/SlackTextViewController/issues?q=is%3Aissue+is%3Aopen+label%3A%22iOS+11%22
Everyone is more than welcomed to contribute. We will release once the most important ones are fixed.

@eliot1019
Copy link

Any ETA on an update @dzenbot ?

@dzenbot
Copy link

dzenbot commented Oct 2, 2017

See my comment above. If you are using Cocoapods or Carthage, you can checkout to a specific commit or branch. You don’t need a release to be able to update anyway.

@petermoser
Copy link

Hi Ignacio, we are experiencing the same issue on iOS11, "Inserting/Deleting cells on iOS 11 causes tableView subviews to be unresponsive" issue #623.
Are there any plans for fixing this or do we need to switch to another library?

@plu
Copy link

plu commented Oct 24, 2017

It seems that the iOS Slack app has moved on to a custom solution

@dzenbot is this true? The Slack app for example supports the panning gesture nicely to close the keyboard. When I clone the repository here and run the examples, this feature does not seem to be working correctly. Would be great to clarify this question. I believe it's important for the community to know.

@jbouaziz
Copy link

jbouaziz commented Oct 24, 2017 via email

@plu
Copy link

plu commented Oct 24, 2017

That feature is native since iOS 8 or 9 if I recall. You need to set the ‘keyboardDismissMode’ property on a scroll view instance.

I know, but it doesn't change the fact that it's not working with SlackTextViewController. Just add this to Messenger-Swift/MessageViewController: self.tableView.keyboardDismissMode = .interactive

Result looks like this (iPhone 5s, 10.3.1 Simulator):

simulator screen shot 24 oct 2017 08 42 08

@dzenbot
Copy link

dzenbot commented Nov 2, 2017

Although there are still known iOS 11 / iPhone X issues, I've pushed 1.9.6 release, which is also available on Cocoapods. At least, we've fixed the most critical issues. Thanks again to all the contributors! 👏

@beamercola
Copy link

@dzenbot it still seems the isKeyboardPanningEnabled isn't working.

setting keyboardDismissMode = .interactive works, but the toolbar doesn't hug the keyboard.

@dzenbot
Copy link

dzenbot commented Jan 26, 2018

@beamercola Please read the docs on that property. It is disabled, on purpose. It no longer works on newer iOS versions.
@plu Sorry for the late response: in short, yes, we are slowly transitioning from SlackTextViewController to a more sophisticated solution, which unfortunately, won't be open sourced.

@scottcc
Copy link

scottcc commented Feb 9, 2018

@dzenbot, I think these statements should be front and center on the README - a large part of the attraction of using something like this is the backing/usage of the owner of the library. There are many of us who have used open source "magic" libraries which have (through normal software lifetimes) become "abandoned" (see https://github.com/jessesquires/JSQMessagesViewController). It's helpful to know straight out that something is going to be "...transitioned from..." by the original author(s).

@beamercola
Copy link

Working maintained fork: https://github.com/GitHawkApp/MessageViewController

@eliburke
Copy link

eliburke commented Feb 9, 2018

@beamercola MessageViewController is not a fork, and it's not feature compatible. I have hopes, but the author has stated "I don’t plan on adding any messaging functionality to this project". At the moment, it is predominantly an autocomplete control (the @, #, / behavior of SlackTextViewController)

I don't know yet what he considers "messaging functionality" but to be a decent replacement for STVC I think it will at least need to have a baseline implementation of an autohiding input bar with support for buttons/toolbar/attachments and a typing indicator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests