Skip to content
This repository has been archived by the owner on Jan 17, 2020. It is now read-only.

Add argument to NotFound constructor which reflects the body of the response. #50

Open
beckyconning opened this issue Jun 16, 2017 · 3 comments

Comments

@beckyconning
Copy link
Contributor

beckyconning commented Jun 16, 2017

/server/licenseInfo returns 404 with the following content

{ "status": "Not Found", "detail": { "message": "validation status error: LICENSE_INVALID" } }

but this seems not to be reflected in the returned QError https://github.com/slamdata/purescript-quasar/blob/master/src/Quasar/Error.purs#L30

if this is the case then its not currently possible to tell between the difference between the license being invalid and the version of quasar not supporting this endpoint (i.e. not advanced).

alternatively perhaps quasar should not be return 404 but rather some other code?

@garyb
Copy link
Member

garyb commented Jun 16, 2017

404 does not seem like the right HTTP status code for this at all, I'm not there's any way you can look at "license invalid" and say that somehow the request was for a resource that doesn't exist 😄

I would suggest this is reopened on Quasar, suggesting it returns a 500 error or something more approriate.

@beckyconning
Copy link
Contributor Author

@drostron @nicflores

@drostron
Copy link

Happy to adjust the response code to 500 if more appropriate. https://github.com/slamdata/quasar-advanced/issues/188

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants