Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound effects (pool ball colliding, pool ball going into pocket) #34

Open
sleddog opened this issue Oct 2, 2017 · 8 comments
Open

Comments

@sleddog
Copy link
Owner

sleddog commented Oct 2, 2017

Would be cool to have sound effects during collisions or when balls are potted.

@ryanimpey
Copy link
Contributor

Hi @sleddog! I've created a pull request for this feature at Pull Request #35

Hope it helps!

@sleddog
Copy link
Owner Author

sleddog commented Oct 3, 2017

that sound is great @ryanimpey thanks! wanna add more for the ball collisions and felt collisions?

@ryanimpey
Copy link
Contributor

I'll take a look at it later today!

@BestDanelleEver
Copy link

Can i please take this?

@sleddog
Copy link
Owner Author

sleddog commented Oct 6, 2017

@BestDanelleEver always open for a PR. Feel free to give it a shot.

@sleddog
Copy link
Owner Author

sleddog commented Oct 8, 2017

@ryanimpey / @BestDanelleEver did you still want to tackle this?

@ryanimpey
Copy link
Contributor

@sleddog Sorry been a bit busy, I'll look into adding some more sounds tomorrow for you

@sleddog
Copy link
Owner Author

sleddog commented Oct 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants