Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vscode): add Slidev language server #1743

Merged
merged 37 commits into from
Jul 20, 2024
Merged

feat(vscode): add Slidev language server #1743

merged 37 commits into from
Jul 20, 2024

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Jul 9, 2024 •
edited by antfu
Loading

Features:

  • Syntax highlighting for frontmatter, code block attributes, and import-snippets
  • Formatting frontmatter
  • A foundation to support code completion inside Slide content in the future

Todos:

  • Switch the language-server package from tsc to tsup
  • Use bundle's language-server instead of importing from node_modules
  • Replace regex with slidev parser in LanguagePlugin
  • Provide schema for volar-service-yaml (deferred to future PR)

(Edited by @KermanX)

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 2bb9d41
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/669bf70295d637000889bc5f
😎 Deploy Preview https://deploy-preview-1743--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnsoncodehk johnsoncodehk changed the title feat: add yaml language support in formatters via Volar integration feat: add yaml language support in frontmatters via Volar integration Jul 9, 2024
@KermanX KermanX changed the title feat: add yaml language support in frontmatters via Volar integration feat(vscode): add Slidev language server Jul 12, 2024
@KermanX KermanX mentioned this pull request Jul 17, 2024
Merged
@KermanX KermanX marked this pull request as ready for review July 17, 2024 13:59
@antfu antfu mentioned this pull request Jul 20, 2024
Closed
@antfu antfu merged commit 73f5b4b into slidevjs:main Jul 20, 2024
18 checks passed
@johnsoncodehk johnsoncodehk deleted the volar-support branch July 22, 2024 12:53
This was referenced Aug 31, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsoncodehk @antfu @KermanX