Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for incorrect touch coordinates with winit on the web #2424

Closed
tronical opened this issue Mar 28, 2023 · 1 comment
Closed

Remove workaround for incorrect touch coordinates with winit on the web #2424

tronical opened this issue Mar 28, 2023 · 1 comment
Assignees
@tronical
Labels
a:backend-winit Winit backend (mS,mO)

Comments

@tronical
Copy link
Member

Once rust-windowing/winit#2704 is merged and released, we can unpick winit in the winit backend and remove the workaround for fixing the coordinates of touch events in wasm builds.
@tronical tronical added bug Something isn't working a:backend-winit Winit backend (mS,mO) labels Mar 28, 2023
@tronical tronical self-assigned this Mar 28, 2023
tronical added a commit that referenced this issue Mar 28, 2023
@tronical
Fix touch events not working for wasm builds
ec20512 
Work around a winit bug for WASM builds by pinning to the exact winit
version and making the coordinates relative again.

cc #2424
tronical added a commit that referenced this issue Mar 28, 2023
@tronical
Fix touch events not working for wasm builds
5879e1e 
Work around a winit bug for WASM builds by pinning to the exact winit
version and making the coordinates relative again.

cc #2424
@ogoffart
Copy link
Member

The commit to revert is #2302 (5879e1e)

ogoffart added a commit that referenced this issue Sep 12, 2023
@ogoffart
Revert "Fix touch events not working for wasm builds"
e71def4 
This reverts commit 5879e1e.

We will update to next version of winit:
Closes #2424

 Conflicts:
	internal/backends/winit/Cargo.toml
	internal/backends/winit/event_loop.rs
	internal/backends/winit/glwindow.rs
	internal/renderers/skia/Cargo.toml
ogoffart added a commit that referenced this issue Sep 25, 2023
@ogoffart
Revert "Fix touch events not working for wasm builds"
ce30615 
This reverts commit 5879e1e.

We will update to next version of winit:
Closes #2424

 Conflicts:
	internal/backends/winit/Cargo.toml
	internal/backends/winit/event_loop.rs
	internal/backends/winit/glwindow.rs
	internal/renderers/skia/Cargo.toml
@ogoffart ogoffart removed the bug Something isn't working label Oct 19, 2023
ogoffart added a commit that referenced this issue Oct 21, 2023
@ogoffart
Revert "Fix touch events not working for wasm builds"
2472b59 
This reverts commit 5879e1e.

We will update to next version of winit:
Closes #2424

 Conflicts:
	internal/backends/winit/Cargo.toml
	internal/backends/winit/event_loop.rs
	internal/backends/winit/glwindow.rs
	internal/renderers/skia/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tronical tronical

Labels
a:backend-winit Winit backend (mS,mO)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tronical @ogoffart