Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: have unit tests use DuckDB test fixture #145

Closed
dogversioning opened this issue Nov 24, 2023 · 1 comment
Closed

Tech Debt: have unit tests use DuckDB test fixture #145

dogversioning opened this issue Nov 24, 2023 · 1 comment

Comments

@dogversioning
Copy link
Contributor

With a local athena equivalent db available, we should be able to use it instead of mocked pyathena cursors, which would be a better test of actual behavior (although we will catch that with regression tests).

We should make a fixture to handle spinup/teardown, and then use that fixture in each test that currently uses a mocked DB curosr.

@dogversioning
Copy link
Contributor Author

completed via #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant