Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move commonly used params to a config class #225

Closed
dogversioning opened this issue Apr 26, 2024 · 2 comments
Closed

Move commonly used params to a config class #225

dogversioning opened this issue Apr 26, 2024 · 2 comments

Comments

@dogversioning
Copy link
Contributor

There are certain values that are used over and over in lots of places:

  • schema
  • cursor
  • parser

We should move these things into a single class, and then pass that around, which should make adding additional widely shared bits of config (like database engine type, which should be moved into this after its created) easier to add in the future if there is a need.

@dogversioning
Copy link
Contributor Author

this is started by #233

@dogversioning
Copy link
Contributor Author

completed via #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant