Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StudyManifestParser #246

Closed
dogversioning opened this issue May 31, 2024 · 1 comment
Closed

Rename StudyManifestParser #246

dogversioning opened this issue May 31, 2024 · 1 comment
Milestone
3.0 Breaking changes

Comments

@dogversioning
Copy link
Contributor

As mentioned in #245, parsing is an implementation detail more than a core facet of this class. So this proposes two changes:

  • Make the class name StudyManifest
  • Rename the file to study_manifest.py
@dogversioning dogversioning added this to the 3.0 Breaking changes milestone May 31, 2024
@dogversioning dogversioning mentioned this issue Jul 1, 2024
Merged
3 tasks
@dogversioning
Copy link
Contributor Author

completed via #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0 Breaking changes
Development

No branches or pull requests
1 participant
@dogversioning