Switch _code_system to _system #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
approved these changes
Jul 11, 2024
| cdc.code_system AS category_code_system, | ||
| cdc.code_system AS category_system, |
There was a problem hiding this comment.
This approach is fine, but I worry that we're setting ourselves up for accidentally using code_system again down the line by not changing the denorm code now to give .system instead of .code_system.
There was a problem hiding this comment.
system is a reserved word in sql, which is how we originally got to this place - it'll be fussier, but we can change it there too, though my soft preference is not to
| CREATE TABLE core__fhir_mapping_code_system_uri AS SELECT * FROM | ||
| CREATE TABLE core__fhir_mapping_system_uri AS SELECT * FROM |
There was a problem hiding this comment.
yeah or i saved at the wrong point - will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_code_systemaliases to just_system#211 with a find/replace of instances of_code_systemin sql and sql templates (excluding the table in fhir_mapping_tables.sql,core__fhir_mapping_code_system_uri, which is correct in that context.Checklist
docs/) needs to be updated