Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting order for GenomicRegion #10

Open
andrewdavidsmith opened this issue Jul 27, 2015 · 3 comments
Open

Sorting order for GenomicRegion #10

andrewdavidsmith opened this issue Jul 27, 2015 · 3 comments

Comments

@andrewdavidsmith
Copy link
Contributor

I think it is now time to change the comparator operators for GenomicRegion and SimpleGenomicRegion. We have been sorting many things now based on the start, then end. @songqiang will feel vindicated by this, but that's ok because I wish he was still working just down the hall...

@timydaley
Copy link
Contributor

I have been sorting this way for a few years now. Primarily for
compatibility with samtools.

On Mon, Jul 27, 2015 at 4:03 PM, Andrew Smith [email protected]
wrote:

I think it is now time to change the comparator operators for
GenomicRegion and SimpleGenomicRegion. We have been sorting many things now
based on the start, then end. @songqiang https://github.com/songqiang
will feel vindicated by this, but that's ok because I wish he was still
working just down the hall...


Reply to this email directly or view it on GitHub
#10.

Timothy Daley
University of Southern California

@andrewdavidsmith
Copy link
Contributor Author

I think we all have, but we have been using different functions than the operator<()

@songqiang
Copy link
Contributor

With this change, we would expect fewer user questions about "ERROR: reads not sorted" :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants