Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin read from averaging mode: undefined behaviour #9

Open
mjmottram opened this issue Oct 1, 2013 · 1 comment
Open

Pin read from averaging mode: undefined behaviour #9

mjmottram opened this issue Oct 1, 2013 · 1 comment
Labels

Comments

@mjmottram
Copy link
Contributor

Firing in sequence mode and then reading the pin before the sequence is complete is currently allowed. This should not be possible; the pin diode readout may not actually be the averaged reading (undefined behaviour). Two updates are needed:

  • Wait until sequence is complete and then read; if reading taken before end of sequence then an invalid flag should be applied to the pin reading.
  • Character should be flushed to buffer following completed sequence (firing via "g" command), only then should pin average commands be sent.
@mnirkko
Copy link

mnirkko commented Oct 26, 2017

I think this has been implemented. See "Waiting for sequence to finish..." type output when attempting to read the PIN values pre-emptively. Suggest closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants