SNOW-1814531 Implement DriverContext interface

snowflakedb · Nov 19, 2024 · 7ef1e22 · 7ef1e22
1 parent e05cc79
commit 7ef1e22
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/auth_test.go b/auth_test.go
@@ -979,7 +979,6 @@ func TestOktaRetryWithNewToken(t *testing.T) {
 }
 
 func TestContextPropagatedToAuthWhenUsingOpen(t *testing.T) {
-	t.Skip("dsnConnector loses context when opening using sql.Open")
 	db, err := sql.Open("snowflake", dsn)
 	assertNilF(t, err)
 	defer db.Close()

diff --git a/driver.go b/driver.go
@@ -33,6 +33,14 @@ func (d SnowflakeDriver) Open(dsn string) (driver.Conn, error) {
 	return d.OpenWithConfig(ctx, *cfg)
 }
 
+func (d SnowflakeDriver) OpenConnector(dsn string) (driver.Connector, error) {
+	cfg, err := ParseDSN(dsn)
+	if err != nil {
+		return Connector{}, err
+	}
+	return NewConnector(SnowflakeDriver{}, *cfg), nil
+}
+
 // OpenWithConfig creates a new connection with the given Config.
 func (d SnowflakeDriver) OpenWithConfig(ctx context.Context, config Config) (driver.Conn, error) {
 	if err := config.Validate(); err != nil {