Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update apache arrow to v16 #1102

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ChronosMasterOfAllTime
Copy link
Contributor

Description

Resolves #1101

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@ChronosMasterOfAllTime ChronosMasterOfAllTime requested a review from a team as a code owner April 17, 2024 14:07
Copy link

github-actions bot commented Apr 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ChronosMasterOfAllTime
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ChronosMasterOfAllTime
Copy link
Contributor Author

recheck

@sfc-gh-dszmolka
Copy link
Contributor

hi and thanks for your contribution! can we maybe revisit this when Arrow v16 is actually released and use the official release ? It's not available yet.

@sfc-gh-dszmolka
Copy link
Contributor

@ChronosMasterOfAllTime Arrow v16 looks to be released now, can you please modify your PR to have the official released v16.0.0 ?

@ChronosMasterOfAllTime
Copy link
Contributor Author

@ChronosMasterOfAllTime Arrow v16 looks to be released now, can you please modify your PR to have the official released v16.0.0 ?

@sfc-gh-dszmolka done!

@sfc-gh-pfus
Copy link
Collaborator

Fantastic! Let's give it a few days to see if there is no critical update on Arrow side. Thanks a lot @ChronosMasterOfAllTime !

@sfc-gh-pfus
Copy link
Collaborator

It turns out, that Arrow 16 requires newer version of Go (1.21). We still support 1.19 so we have to put it on hold.

@sfc-gh-pfus sfc-gh-pfus added the status-blocked Progressing the issue is blocked by something, probably dependencies. label Apr 24, 2024
@Yifeng-Sigma
Copy link
Contributor

It turns out, that Arrow 16 requires newer version of Go (1.21). We still support 1.19 so we have to put it on hold.

do we have a rough timeline of when we will do this upgrade?

@sfc-gh-pfus
Copy link
Collaborator

We (with @sfc-gh-sthyagaraj , our PM) are still working on all aspects (including legal) of deprecating old language versions. I can't make the promises, but I've been pushing this issue for a long time...

@sfc-gh-pfus
Copy link
Collaborator

Hi @ChronosMasterOfAllTime ! We dropped support for 1.20 which was a blocker for this one. Would you like to continue working on it (rebase and solve conflicts)?

@sfc-gh-pfus sfc-gh-pfus removed the status-blocked Progressing the issue is blocked by something, probably dependencies. label Nov 19, 2024
@sfc-gh-pfus
Copy link
Collaborator

Hi @ChronosMasterOfAllTime ! Pinging again - do you want to continue working on upgrading Arrow or you want me to finish it?

@ChronosMasterOfAllTime
Copy link
Contributor Author

ChronosMasterOfAllTime commented Nov 19, 2024

Sure I can do a quick rebase @sfc-gh-pfus

@ChronosMasterOfAllTime
Copy link
Contributor Author

FYI: https://arrow.apache.org/blog/2024/10/23/arrow-go-18.0.0-release/ for when you bump to go 1.22

@sfc-gh-pfus sfc-gh-pfus merged commit 11cccfd into snowflakedb:master Nov 21, 2024
35 of 38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@sfc-gh-pfus
Copy link
Collaborator

PR merged, thank you @ChronosMasterOfAllTime !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1333232 High Severity DoS CVE in introduced - github.com/hambra/avro
6 participants