SNOW-1754426 Fix duplicated requestId and request_guid params #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-1754426-fix-duplicated-query-params
branch
from
eb3e2b3 to
6c5907f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
+ Coverage 82.78% 82.79% +0.01%
==========================================
Files 55 55
Lines 13194 13194
==========================================
+ Hits 10922 10924 +2
+ Misses 2272 2270 -2 ☔ View full report in Codecov by Sentry. |
sfc-gh-pbulawa
approved these changes
Oct 22, 2024
sfc-gh-pmotacki
approved these changes
Oct 23, 2024
sfc-gh-dheyman
approved these changes
Oct 23, 2024
sfc-gh-mkubik
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1754426 While migrating from Nginx to Envoy it was observed that when session expired and request was retried after renewal,
requestIdandrequest_guidparams where duplicated. The reason was that headers were added to existing value list instead of being replaced.Checklist