Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1786800: Go Toml Configuration and Python Toml Configuration are subtely different in connections.toml #1236

Closed
costrouc opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@costrouc
Copy link

costrouc commented Nov 4, 2024

This library provides a utility for reading connection configuration from a connections.toml file https://github.com/snowflakedb/snowflake-connector-python/blob/48fba63eb1ec672a3c70da1b367ac19314892b30/src/snowflake/connector/connection.py#L185. This is helpful but the connection parameters do not match the parameters used in the python snowflake connector https://github.com/snowflakedb/snowflake-connector-python/blob/main/src/snowflake/connector/connection.py#L158.

Some examples

Python Go
private_key privatekey
private_key_file N/A
private_key_file_pwd N/A
session_id N/A

Snowflake recommends encrypting privatekeys and does not support this option.

This is just a general request to have consistency between the different language libraries and the connection configuration information they read. The python connector is seeing significant adoption due to snow cli.

@costrouc costrouc added the bug Erroneous or unexpected behaviour label Nov 4, 2024
@github-actions github-actions bot changed the title Go Toml Configuration and Python Toml Configuration are subtely different in connections.toml SNOW-1786800: Go Toml Configuration and Python Toml Configuration are subtely different in connections.toml Nov 4, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 5, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage Issue is under initial triage label Nov 5, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - the request is absolutely reasonable, and I wish the various drivers for various programming languages were developed right from the start with a common set of requirements.
but they weren't, and are more or less divergent.

since a year or so, I see a tendency that now there are unified requirements which we strive to implement similarly across the various drivers, and also if possible, maintain parity between them (to have the same functionality at least between the most popular drivers)

so this request is while reasonable, i'm not entirely convinced is raised at the right place. name of settings should be consistent across all the drivers, not just between Python and Go drivers.

since it affects other libraries as well, for the 'general' part in your general request, you can reach out to your account team and word this enhancement to be necessary across all the drivers. for the gosnowflake library for which you raise it, we can of course consider.

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team and removed bug Erroneous or unexpected behaviour status-triage Issue is under initial triage labels Nov 5, 2024
@costrouc
Copy link
Author

costrouc commented Nov 7, 2024

I'll close this and just keep talking with people within Snowflake. Thanks for responding to the issue. We use a wide range of Snowflake tools from it/data engineering. I'm trying to raise more awareness of this issue. At this point we need 5 configuration files and never exactly know what the environment variables are.

@costrouc costrouc closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

3 participants