Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1787174: Move "Authentication FAILED" and "Authentication SUCCESS" to Debug logging #1237

Closed
rohantandon opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
question Issue is a usage/other question rather than a bug status-triage_done Initial triage done, will be further handled by the driver team wontfix

Comments

@rohantandon
Copy link

rohantandon commented Nov 4, 2024

What is the current behavior?

Currently, the following lines print an ERROR log and an INFO log when authenticating:

These lines are noisy and should be moved to Debug logging. The authenticate() function already returns an error, which can contain an authentication failure without the need for an error-level log message which can get noisy

What is the desired behavior?

gosnowflake shouldn't issue a log message on successful or failed authentication at the error or info level. These should be debug level.

How would this improve gosnowflake?

This would drastically reduce the noise of the library, which is set to error with no ability for the client to set this. Especially for services like credential rotators, ensuring that an old credential is no longer valid is a pertinent use case, and log messages can quickly accumulate

References, Other Background

@github-actions github-actions bot changed the title Move "Authentication FAILED" and "Authentication SUCCESS" to Debug logging SNOW-1787174: Move "Authentication FAILED" and "Authentication SUCCESS" to Debug logging Nov 4, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Nov 5, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added question Issue is a usage/other question rather than a bug wontfix status-triage_done Initial triage done, will be further handled by the driver team labels Nov 5, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - thanks for raising this.

i'm not entirely sure what

[..]which is set to error with no ability for the client to set this

means in this context of ability to set loglevel. you can use the user-facing Tracing property on Config to configure the desired loglevel (range: trace, debug, info, print, warning, error, fatal, panic), reference , or if that's an option for you, SetLogger to set a customized logger reference

Hope one of them helps in setting up the loglevel in your application which makes the most sense for you.

@sfc-gh-dszmolka sfc-gh-dszmolka closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
@rohantandon
Copy link
Author

rohantandon commented Nov 5, 2024

Thanks for the pointer to how to change the said log level. I'll look into a fork for the specific log line changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue is a usage/other question rather than a bug status-triage_done Initial triage done, will be further handled by the driver team wontfix
Projects
None yet
Development

No branches or pull requests

2 participants