Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-559970: Add error cast check for SnowflakeError #563

Closed
wants to merge 3 commits into from

Conversation

satishbhor
Copy link

@satishbhor satishbhor commented Mar 15, 2022

checkQueryStatus API not always returns SnowflakeError, e.g. if context is cancelled by client then it may return *errors.errorString, Hence we should have check whether its SnowflakeError or not, otherwise it will panic and will crash app.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@satishbhor
Copy link
Author

Hello Team,
Any update on this?

@sfc-gh-dszmolka
Copy link
Contributor

#771

@sfc-gh-pfus
Copy link
Collaborator

Hello @satishbhor ! Thanks for your input, this is very valuable. Can you rebase and solve conflicts?

@sfc-gh-pfus
Copy link
Collaborator

I noticed, that the only place in which we use casting to snowflakeError was already fixed (as @sfc-gh-dszmolka kindly suggested). So I think that we don't need a dedicated function for casting to snowflakeError.
In that case I'm going to close this PR, but personally I'm always happy if community suggests improvements. Thank you very much! I hope, that in some time you will provide another improvement or a bug fix!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants