test: use T.TempDir to create temporary test directory

[Juneezee]

Description

A testing cleanup.

This pull request replaces ioutil.TempDir with t.TempDir. We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	if err != nil {
		t.Error(err)
	}
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}

Checklist

• Code compiles correctly
• Run make fmt to fix inconsistent formats
• Run make lint to get lint errors and fix all of them
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[Juneezee]

I have read the CLA Document and I hereby sign the CLA

[Juneezee]

Hello @sfc-gh-dszmolka @sfc-gh-igarish . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago.

I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them.

Thank you for your time and consideration. I truly appreciate it. ❤️

[sfc-gh-igarish]

@Juneezee In original code it was using pattern (the second argument) in each MkdirTemp call. How the replacement call works for the same?

[Juneezee]

@Juneezee In original code it was using pattern (the second argument) in each MkdirTemp call. How the replacement call works for the same?

@sfc-gh-igarish t.TempDir() uses the test name as the directory name, You can see an example here: https://go.dev/play/p/OtvRbfHywtk

[Juneezee]

friendly ping @sfc-gh-igarish

[sfc-gh-igarish]

LGTM

[Juneezee]

Hi @sfc-gh-igarish, please re-run the failing tests. I think the failing tests are not related to this PR. Thanks.

[sfc-gh-igarish]

@Juneezee Please update the branch. Even if it's not related to this PR, it's a merge gate. I will try again once you update the branch.

[sfc-gh-igarish]

@Juneezee These are the failures, which I believe related to this PR:
RUN TestEncryptDecryptFilePadding
testing.go:1097: TempDir RemoveAll cleanup: remove C:\Users\RUNNER1\AppData\Local\Temp\TestEncryptDecryptFilePadding3894548605\006\file65544: The process cannot access the file because it is being used by another process.
--- FAIL: TestEncryptDecryptFilePadding (3.80s)
=== RUN TestEncryptDecryptLargeFile
testing.go:1097: TempDir RemoveAll cleanup: remove C:\Users\RUNNER1\AppData\Local\Temp\TestEncryptDecryptLargeFile100552289\001\file0: The process cannot access the file because it is being used by another process.
--- FAIL: TestEncryptDecryptLargeFile (2.09s)

[Juneezee]

@sfc-gh-igarish

Windows handle open files differently so we need to close all open file descriptors explicitly. I've found a few places where we missed adding .Close(), and I have added them in the latest commit. Let's try running test again. Thanks!

[sfc-gh-pfus]

LGTM

[sfc-gh-pfus]

Thank you very much @Juneezee for your input! I merged your PR :)