SNOW-892592: Fix panic when SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED=false #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-lb
force-pushed
the
fixPanicWithOcspCacheServerDisabled
branch
from
340f230 to
74f04e1
Compare
sfc-gh-ext-simba-lb
force-pushed
the
fixPanicWithOcspCacheServerDisabled
branch
from
74f04e1 to
b36df6c
Compare
sfc-gh-pfus
reviewed
Aug 16, 2023
| func TestCacheServerDisabled(t *testing.T) { | ||
| _ = os.Setenv(cacheServerEnabledEnv, "false") | ||
|
|
||
| if _, err := buildSnowflakeConn(context.Background(), Config{ |
There was a problem hiding this comment.
Can extract building sf conn outside of the if? Or at least Config? Now it's not very readable.
| } | ||
|
|
||
| ocspURL := os.Getenv(cacheServerURLEnv) | ||
| if ocspURL != "" { |
There was a problem hiding this comment.
I'm not sure if I understand it. According to the first line in the test, you just set an env variable and now you read another one. I believe this just reads env variable, there is no driver logic. The only reason why this could work is that buildSnowflakeConn removes this env var, which seems unlike. But if this should work, maybe we should enrich the test with setting cacheServerUrlEnv at the beginning of the test?
|
Closing this PR since I can't reproduce the original issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/608
When testing for https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/593 I found a panic when SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED is false. The initOcspCache() function initializes a mutex lock on the ocsp response cache. If SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED=false it exits the init function before the lock is initialized. The driver tries to access it later and it causes a panic during connection.
This change is to initialize the lock first and then check for SF_OCSP_RESPONSE_CACHE_SERVER_ENABLED.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them