Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-856228] not to log to the console when easy logging configured … #952

Conversation

sfc-gh-knozderko
Copy link
Collaborator

…to log to the file

Description

Make possible to log to the file without logging to console output.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 31, 2023 13:51
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #952 (314fc3b) into master (1f9df02) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   83.80%   83.85%   +0.05%     
==========================================
  Files          50       50              
  Lines        9556     9556              
==========================================
+ Hits         8008     8013       +5     
+ Misses       1548     1543       -5     
Files Coverage Δ
easy_logging.go 77.06% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-knozderko sfc-gh-knozderko changed the title [SNOW-856233] not to log to the console when easy logging configured … [SNOW-856228] not to log to the console when easy logging configured … Oct 31, 2023
@sfc-gh-knozderko sfc-gh-knozderko merged commit 56c3618 into master Oct 31, 2023
23 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856233_easy_logging_not_log_to_console_when_log_to_file branch October 31, 2023 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants