Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr 955 #957

Closed
wants to merge 2 commits into from
Closed

Test pr 955 #957

wants to merge 2 commits into from

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 6, 2023 13:19
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #957 (857b610) into master (56c3618) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   83.80%   83.84%   +0.04%     
==========================================
  Files          50       50              
  Lines        9556     9557       +1     
==========================================
+ Hits         8008     8013       +5     
+ Misses       1548     1544       -4     
Files Coverage Δ
connection.go 85.32% <100.00%> (+0.76%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sfc-gh-pfus sfc-gh-pfus closed this Nov 6, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the test_pr_955 branch November 6, 2023 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants