Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-981533 Add 503 and contentType check for monitoring query response #981

Closed
wants to merge 1 commit into from

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (15fac29) 82.48% compared to head (7b9044c) 82.74%.
Report is 1 commits behind head on master.

Files Patch % Lines
monitoring.go 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
+ Coverage   82.48%   82.74%   +0.26%     
==========================================
  Files          50       50              
  Lines        9643     9652       +9     
==========================================
+ Hits         7954     7987      +33     
+ Misses       1689     1665      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@sfc-gh-dheyman
Copy link
Collaborator Author

This solution won't fix the whole issue.

@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-981533-eof-fix branch December 5, 2023 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant