Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1660331 export SnowflakeFileTransferOptions.GetFileToStream #1208

Merged

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Description

SNOW-1660331 // #1207

attempt to fix

unknown field getFileToStream in struct literal of type gosnowflake.SnowflakeFileTransferOptions

which happens when trying to download a file into an in-memory stream (rather than a file) per docs:

ctx := WithFileTransferOptions(context.Background(), &SnowflakeFileTransferOptions{getFileToStream: true})
ctx = WithFileGetStream(ctx, &streamBuf)

getFileToStream being unexported, it is not really accessible from outside of the module.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (099708d) to head (4c28228).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   82.52%   82.46%   -0.07%     
==========================================
  Files          54       54              
  Lines       12916    12916              
==========================================
- Hits        10659    10651       -8     
- Misses       2257     2265       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit 3428b00 into master Sep 25, 2024
36 of 37 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-1660331-export-SnowflakeFileTransferOptions branch September 25, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants