Add connection parameters for query context cache and retry context

snowflakedb · Sep 22, 2023 · ec1d2b8 · ec1d2b8
1 parent 134fa03
commit ec1d2b8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/php_pdo_snowflake_int.h b/php_pdo_snowflake_int.h
@@ -96,5 +96,7 @@ enum {
 #define PDO_SNOWFLAKE_CONN_ATTR_PRIV_KEY_FILE_PWD_IDX 14
 #define PDO_SNOWFLAKE_CONN_ATTR_PROXY_IDX 15
 #define PDO_SNOWFLAKE_CONN_ATTR_NO_PROXY_IDX 16
+#define PDO_SNOWFLAKE_CONN_ATTR_DISABLE_QUERY_CONTEXT_CACHE_IDX 17
+#define PDO_SNOWFLAKE_CONN_ATTR_INCLUDE_RETRY_REASON_IDX 18
 
 #endif /* PHP_PDO_SNOWFLAKE_INT_H */
diff --git a/snowflake_driver.c b/snowflake_driver.c
@@ -579,7 +579,9 @@ pdo_snowflake_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{{ */
         {"priv_key_file",       NULL,         0},
         {"priv_key_file_pwd",   NULL,         0},
         {"proxy",               NULL,         0},
-        {"no_proxy",            NULL,         0}
+        {"no_proxy",            NULL,         0},
+        {"disablequerycontextcache", "false", 0},
+        {"includeretryreason",  "true",       0}
     };
 
     // Parse the input data parameters
@@ -768,6 +770,22 @@ pdo_snowflake_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /* {{{ */
     PDO_LOG_DBG(
         "no_proxy: %s", vars[PDO_SNOWFLAKE_CONN_ATTR_NO_PROXY_IDX].optval);
 
+    snowflake_set_attribute(
+        H->server, SF_CON_DISABLE_QUERY_CONTEXT_CACHE,
+        (strcasecmp(vars[PDO_SNOWFLAKE_CONN_ATTR_DISABLE_QUERY_CONTEXT_CACHE_IDX].optval, "true") == 0) ?
+            &SF_BOOLEAN_TRUE : &SF_BOOLEAN_FALSE);
+    PDO_LOG_DBG(
+        "disablequerycontextcache: %s",
+        vars[PDO_SNOWFLAKE_CONN_ATTR_DISABLE_QUERY_CONTEXT_CACHE_IDX].optval);
+
+    snowflake_set_attribute(
+        H->server, SF_CON_INCLUDE_RETRY_REASON,
+        (strcasecmp(vars[PDO_SNOWFLAKE_CONN_ATTR_INCLUDE_RETRY_REASON_IDX].optval, "true") == 0) ?
+            &SF_BOOLEAN_TRUE : &SF_BOOLEAN_FALSE);
+    PDO_LOG_DBG(
+        "includeretryreason: %s",
+        vars[PDO_SNOWFLAKE_CONN_ATTR_INCLUDE_RETRY_REASON_IDX].optval);
+
     if (snowflake_connect(H->server) > 0) {
         pdo_snowflake_error(dbh);
         goto cleanup;

diff --git a/tests/connect.phpt b/tests/connect.phpt
@@ -7,7 +7,7 @@ pdo_snowflake.cacert=libsnowflakeclient/cacert.pem
     include __DIR__ . "/common.php";
 
     // full parameters
-    $dbh = new PDO("$dsn;application=phptest;authenticator=snowflake;priv_key_file=tests/p8test.pem;priv_key_file_pwd=test", $user, $password);
+    $dbh = new PDO("$dsn;application=phptest;authenticator=snowflake;priv_key_file=tests/p8test.pem;priv_key_file_pwd=test;disablequerycontext=true;includeretryreason=false", $user, $password);
     // create table for testing autocommit later
     $tablename = "autocommittest" . rand();
     $count = $dbh->exec("create or replace table " . $tablename . "(c1 int)");