Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1367604: Add PHP 8.3 Support #382

Closed
aldobarr opened this issue May 6, 2024 · 5 comments
Closed

SNOW-1367604: Add PHP 8.3 Support #382

aldobarr opened this issue May 6, 2024 · 5 comments
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@aldobarr
Copy link

aldobarr commented May 6, 2024

What is the current behavior?

PHP 8.3 is not supported

What is the desired behavior?

PHP 8.3 is supported

How would this improve pdo_snowflake?

PHP 8.3 is already starting to be upgraded to by many production environments. However any system relying on snowflake is unable to do so.

References, Other Background

N/A

What is your Snowflake account identifier, if any?

N/A
@github-actions github-actions bot changed the title Add PHP 8.3 Support SNOW-1367604: Add PHP 8.3 Support May 6, 2024
@salvor-hardin
Copy link

I have php 8.3.6 and this driver has worked fine every version of 8.3.x

@aldobarr
Copy link
Author

aldobarr commented May 6, 2024 •
edited
Loading

I have php 8.3.6 and this driver has worked fine every version of 8.3.x

Hm, it did not compile for me, also PHP 8.3 is not explicitly stated in the readme while other versions are specifically called out which led me to believe that it's not supported

@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this May 6, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team labels May 6, 2024
@sfc-gh-dszmolka
Copy link
Contributor

sfc-gh-dszmolka commented May 6, 2024 •
edited
Loading

hi there - thank you for your interest in this driver and adding PHP8.3 support ! Coincidentally, it's already something on the table :) so we definitely planning to do it. Timeline-wise, I'll need to confirm it with the team internally. Will update this thread once any information is available on the expected timeline.

edit: estimated delivery for official PHP8.3 support is May (end of month); but the main branch should work with PHP8.3 even now if someone would feel like trying.

@sfc-gh-dszmolka sfc-gh-dszmolka removed their assignment May 6, 2024
@sfc-gh-dszmolka
Copy link
Contributor

sfc-gh-dszmolka commented May 29, 2024 •
edited
Loading

(relevant PR is #383, already merged, waiting for release)

edit: release is expected to be available towards mid June 2024

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label May 29, 2024
@sfc-gh-dszmolka
Copy link
Contributor

PHP 8.3 support released with v3.0.0 (and PHP 8.0 deprecated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aldobarr @salvor-hardin @sfc-gh-dszmolka