Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-871412 SNOW736357: Add connection parameters for query context cache and retry context #341

Merged
3 commits merged into from
Sep 23, 2023
Merged

SNOW-871412 SNOW736357: Add connection parameters for query context cache and retry context #341

3 commits merged into from
Sep 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2023 •
edited by ghost
Loading

Add two connection parameters to control the behavior of HTAP changes:

  • disablequerycontextcache : When its true, disable query context cache feature so no query context will be send back to the server in query request. Defaults to false.
  • includeretryreason : Whether to include retry reason in retry for query request. Defaults to true.

no visible test result can be verified in test case htap.phpt, while the behavior can be verified through driver log.

@ghost ghost self-requested a review as a code owner September 22, 2023 13:53
@ghost ghost requested a review from sfc-gh-igarish September 22, 2023 13:54
@ghost ghost requested a review from sfc-gh-dprzybysz September 22, 2023 18:41
sfc-gh-igarish
sfc-gh-igarish approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 224b010 into master Sep 23, 2023
13 checks passed
@ghost ghost deleted the SNOW-871412-SNOW-736357-HTAP-changes branch September 23, 2023 00:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz Awaiting requested review from sfc-gh-dprzybysz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-ext-simba-hx