Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-828206: Passwords containing only [ or ] RFC 1738 non-compliant #415

Open
JDarDagran opened this issue May 26, 2023 · 1 comment · May be fixed by #416
Open

SNOW-828206: Passwords containing only [ or ] RFC 1738 non-compliant #415

JDarDagran opened this issue May 26, 2023 · 1 comment · May be fixed by #416
Labels
bug Something isn't working status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team

Comments

@JDarDagran
Copy link

Please answer these questions before submitting your issue. Thanks!

  1. What version of Python are you using?

3.10

  1. What operating system and processor architecture are you using?

Linux-5.10.60.1-microsoft-standard-WSL2-x86_64-with-glibc2.35

  1. What are the component versions in the environment (pip freeze)?

//

  1. What did you do?
from snowflake.sqlalchemy import URL
from urllib.parse import urlparse

urlparse(URL(password='mypass]')) # throws exception
  1. What did you expect to see?

] should be encoded the same way as :@/ characters defined here: https://github.com/snowflakedb/snowflake-sqlalchemy/blob/main/src/snowflake/sqlalchemy/util.py#L24
@JDarDagran JDarDagran added bug Something isn't working needs triage labels May 26, 2023
@github-actions github-actions bot changed the title Passwords containing only [ or ] RFC 1738 non-compliant SNOW-828206: Passwords containing only [ or ] RFC 1738 non-compliant May 26, 2023
@JDarDagran JDarDagran linked a pull request May 26, 2023 that will close this issue
Open
4 tasks
@sfc-gh-dszmolka
Copy link
Contributor

hi and thank you for submitting this issue and especially for the PR solving it. hopefully it can be reviewed soon by someone from the connector team

@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Mar 20, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Mar 20, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status-pr_pending_merge A PR is made and is under review status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add [ and ] to _rfc_1738_quote. JDarDagran/snowflake-sqlalchemy
2 participants
@JDarDagran @sfc-gh-dszmolka