Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PARTITION BY option for CopyInto #431

Closed
wants to merge 1 commit into from

Conversation

azban
Copy link
Contributor

@azban azban commented Jul 28, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-878116: CopyInto does not support the PARTITION BY clause #430

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

This adds an argument to CopyInto which can be used to specify a string value for PARTITION BY. I have a few questions about implementation:

  1. Would it be better to adhere to the convention of having functions that do some validation similar to those used for CopyInto.copy_options? If so, is there any particular validation to make sense?
  2. Is there a preference towards implementing this as a clause rather than allowing for a string? I'm not very familiar with custom clauses, and I don't know of a similar implementation that would be useful to base this on.
  3. Unrelated to implementation, but is there a straightforward way to run tests locally? i.e. is there an example parameters file that can be used?

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@azban
Copy link
Contributor Author

azban commented Jul 28, 2023

I have read the CLA Document and I hereby sign the CLA

@azban
Copy link
Contributor Author

azban commented Jul 28, 2023

recheck

@azban azban force-pushed the azban/copy-into-partition-by branch from 99e4eae to b36cff7 Compare July 29, 2023 20:48
@azban azban force-pushed the azban/copy-into-partition-by branch 2 times, most recently from 3783fdf to b36cff7 Compare August 15, 2023 18:02
@azban
Copy link
Contributor Author

azban commented Sep 14, 2023

can anyone please take a look at this?

@azban
Copy link
Contributor Author

azban commented Jan 21, 2024

what's the process for this repo considering and accepting PR's? should we assume we should maintain our own forks long-term?

@azban
Copy link
Contributor Author

azban commented Jul 3, 2024

annual bump =/

@afavaro
Copy link

afavaro commented Nov 4, 2024

@sfc-gh-dszmolka @sfc-gh-astus @sfc-gh-mraba

Any chance we could get a review on this? We're still maintaining our own fork of this library so that we can use this feature.

@sfc-gh-dszmolka
Copy link
Contributor

hi @afavaro and everyone; first of all, i regret it takes such a long time for the team to review this PR. I don't have any explanation which can be shared publicly.

However what I think could work, if you please reach out to your Snowflake account teams and express how this PR is important to you. This could help getting more attention on this PR, and hopefully, this product in general. Thank you in advance and I'm really sorry for this.

@sfc-gh-lcalderonachio
Copy link
Contributor

Hi @azban
Thanks for your contribution, these changes have been merged in #542 with some additional changes. I'll be closing this PR now

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-878116: CopyInto does not support the PARTITION BY clause
4 participants