Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SipNoteUpdateView.get_form() and SipNoteForm.__init__() seemingly do the same thing #21

Open
toraritte opened this issue May 20, 2023 · 0 comments

Comments

@toraritte
Copy link
Member

Both set the input labels of the same form to the same values. If I interpreted the evaluation steps when stepping through a request with PDB:

  • SipNoteForm is only used when a new note is created.

  • When a SIP note is updated via SipNoteUpdateView, it doesn't use the existing SipNoteForm (for some reason), but creates a generic form from scratch on the spot instead, which, confusingly, will also be called SipNoteForm. (The fully qualified names will differ though: django.forms.widgets.SipNoteForm instead lynx.forms.SipNoteForm.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant