-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WireRestShape] Introduce use of RodSectionMaterial #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: clean
pr: new feature
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 4, 2022
fredroy
requested changes
Oct 11, 2022
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 10, 2023
epernod
changed the title
[WireRestShape] Introduce use of WireSectionMaterial
[WireRestShape] Introduce use of RodSectionMaterial
Jun 30, 2023
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jun 30, 2023
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Sep 6, 2023
…eSetTopologyModifier
…ded material1 and material2
# Conflicts: # BeamAdapter_test/component/model/WireRestShape_test.cpp # src/BeamAdapter/component/engine/WireRestShape.h # src/BeamAdapter/component/engine/WireRestShape.inl
…struments deployments
Last call before merging (as the new regression ref are working #121 ) |
fredroy
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Dec 4, 2023
This seems to me to be a positive step towards simulating a wider range of tools. |
Closed
epernod
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new set of classes which hold the mechanical property and the topology (visual and collision) description of a section of the Rod/Wire.
Thoses classes are components to be placed in the graph and linked to the WireRestShape. All the Data which were managed by the WireRestShape have been moved to these new components. Here is the new usage:
For a simple spire catheter:
For a catheter with a mesh describing the tip:
wireMaterials
.densityOfBeams
andkeyPoints
are automatically computedStill to be done:
This PR is still a draft to discuss the design. Some features have not been moved yet: