TST/DOC: Add a test for vanhove and fix the documented example. #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem reported in #394 is still a mystery to me, but it did highlight
that the
vanhove
function has no test coverage. Here is a simple smoketest. It passes for me locally, in a fresh environment with the latest version
of all the required dependencies (obtained via pip):
The documented example was missing a required argument (
lagtime
). I fixedthat.