Merge pull request #115 from softflow24/chore/cleanup

chore/cleanup
softflow24 · Oct 9, 2024 · b813e7a · b813e7a
2 parents 903efd5 + 908076a
commit b813e7a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 106 deletions.
diff --git a/examples/using-database-plugin.ts b/examples/using-database-plugin.ts
diff --git a/examples/workflow.json b/examples/workflow.json
diff --git a/packages/execution-engine/src/ExecutionEngine.ts b/packages/execution-engine/src/ExecutionEngine.ts
@@ -11,7 +11,6 @@ import { IExecutionResult } from "@data-river/shared/interfaces/IExecutionResult
 import { VariableResolver } from "./VariableResolver";
 import { IExecutionStrategy } from "./strategies/IExecutionStrategy";
 import { ILogger } from "@data-river/shared/interfaces/ILogger";
-import { forEach } from "lodash";
 
 @injectable()
 export class ExecutionEngine {
@@ -244,6 +243,8 @@ export class ExecutionEngine {
   ): {
     errors: Error[];
   } {
+    this.logger.error(`Error in block ${blockConfig.id}:`, error);
+
     if (blockConfig.onError) {
       try {
         blockConfig.onError(error, blockConfig);
@@ -255,7 +256,6 @@ export class ExecutionEngine {
         return { errors: [error as Error] };
       }
     }
-    this.logger.error(`Error in block ${blockConfig.id}:`, error);
 
     return { errors: [error] };
   }

diff --git a/packages/shared/src/utils/logger/index.ts b/packages/shared/src/utils/logger/index.ts
@@ -35,7 +35,7 @@ export default class DefaultLogger implements ILogger {
 
   group(message: string): void {
     if (this.shouldLog("info")) {
-      console.group(chalk.bold(message)); // Using console.group for grouping
+      console.group(chalk.bold(message));
     }
   }