Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of blocks #128

Closed
1 task done
itsWindows11 opened this issue Oct 13, 2024 · 4 comments
Closed
1 task done

Deletion of blocks #128

itsWindows11 opened this issue Oct 13, 2024 · 4 comments

Comments

@itsWindows11
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Summary 💡

Being able to press the Del key, or right clicking on the block & selecting "Delete" should delete the block. Neither options currently exist.

The blocks that depend on the one that's deleted can be disconnected from the rest before it, but the workflow must not be able to run while it's disconnected.

Start & end blocks cannot be removed, and a toast pop-up should warn of that.

Examples 🌈

No response

Motivation 🔦

Deleting blocks is necessary in case the wrong block type is added by accident, or when a user wants to reset a block's settings.

@c0rtexR
Copy link
Contributor

c0rtexR commented Oct 13, 2024

@itsWindows11 try backspace :)

Altho let's come up with how we can improve this

@itsWindows11
Copy link
Contributor Author

itsWindows11 commented Oct 14, 2024

Backspace isn't a well known shortcut for deleting items, maybe for characters but a block isn't a character 🤷‍♂️

@c0rtexR
Copy link
Contributor

c0rtexR commented Oct 14, 2024

Backspace isn't a well known shortcut for deleting items, maybe for characters but a block isn't a character 🤷‍♂️

I think it just comes like this by default from react-flow because of macs, most don't even have a delete button 😆
With that being said, i do believe we can do better with handling this. I will mock something up for the context menu

@c0rtexR
Copy link
Contributor

c0rtexR commented Oct 14, 2024

I'm closing the issue as it works, the UI just does not indicate to the user what are the shortcuts so can be confusing if you are used to windows. Instead i have created an issue to address this by better UI on this issue #136

@c0rtexR c0rtexR closed this as completed Oct 14, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in data-river Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants