Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

422 backend commits with same timestamp should be downgraded in severity to warning #440

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

422 backend commits with same timestamp should be downgraded in severity to warning #440

wants to merge 10 commits into from

Conversation

frozenfrank
Copy link
Contributor

Resolves #422.

This PR:

  • Will introduce tests to verify that the new functionality counts commits correctly
  • Adjusts the language and severity of some common student git mistakes
  • Preserves the mathematical correctness of the grading process and rigidity of requirements while also being forgiving of unintentional effects
  • May refactor parts of the commit verification system to account for new kinds of data flows

@frozenfrank frozenfrank added the enhancement New feature or request label Oct 17, 2024
@frozenfrank frozenfrank self-assigned this Oct 17, 2024
frozenfrank and others added 10 commits October 26, 2024 10:30
@frozenfrank
Rework GitHelper.commitsPassRequirements() to separate warnings from …
3493d3d 
…errors
@frozenfrank
Refactor CommitValidation into a subpackage
f3e4518
@frozenfrank
Minor adjustments: Clean imports and suppress acknowledged error in l…
fa2858a 
…inking
@frozenfrank
CommitVerificationResult exposes the warning messages along with modi…
b3ca7ad 
…fied totals
@frozenfrank
Calculate and separately report only follow-on commit hashes...
e5b1d9e 
We want to be able to exclude these hashes from a processing re-run
but still give credit for one of the commits that contained changes.
@frozenfrank
Provide data structures to track the commit hashes of warned commits
2f7889d
@frozenfrank
Comment adjustments
225e613
@frozenfrank
Reclassify and reword out-of-order message
44b0114
@frozenfrank
Update test to reflect downgraded severity of out of order commits
11f2373
@frozenfrank
Actually use the subsequent commits for grading
898421e
@frozenfrank frozenfrank force-pushed the 422-backend-commits-with-same-timestamp-should-be-downgraded-in-severity-to-warning branch from ee129e7 to 898421e Compare October 26, 2024 16:30
@frozenfrank frozenfrank mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frozenfrank frozenfrank

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend: Commits with Same Timestamp should be downgraded in severity to warning
1 participant
@frozenfrank