Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Commits with Same Timestamp should be downgraded in severity to warning #422

Open
frozenfrank opened this issue Sep 17, 2024 · 0 comments · May be fixed by #440
Open

Backend: Commits with Same Timestamp should be downgraded in severity to warning #422

frozenfrank opened this issue Sep 17, 2024 · 0 comments · May be fixed by #440
Assignees
Labels
enhancement New feature or request

Comments

@frozenfrank
Copy link
Contributor

frozenfrank commented Sep 17, 2024

Overview

One of the mechanisms designed to catch cheating students is providing many false positives with ignorant students.
To streamline the student learning experience, we want to reduce that by converting some conditions currently marked as errors to mere warnings. We can leverage the observer.notifyWarning() to send warning text that will be displayed to students.

Current Failure Conditions & Messages

We want to downgrade the following conditions:

  • Suspicious commit history. Multiple commits have the exact same timestamp.
  • Suspicious commit history. Not all commits are in order.

@19mdavenport Would you like any other messages to be downgraded in severity as well?

  • String.format("Not enough commits to pass off (%d/%d).", numCommits, requiredCommits)
  • String.format("Have some commits, but some of them are too insignificant for credit (%d/%d).", significantCommits, requiredCommits)
  • String.format("Did not commit on enough days to pass off (%d/%d).", daysWithCommits, requiredDaysWithCommits)
  • "Suspicious commit history. Some commits are authored after the hand in date."
  • "Suspicious commit history. Some commits are authored before the previous phase hash."
  • "Suspicious commit history. Some commits have been backdated."
  • "Missing tail hash. The previous submission commit could not be found in the repository."

Difficulty

We'll need to improve our logic to remove discount any of the commits included in the warning conditions. We can subtract them from the total number of valid commits.

It would be more difficult to re-process the number of unique days. That shouldn't matter with the current set of warning conditions, but it could matter with future warning conditions and may be worth designing a more general approach.

@frozenfrank frozenfrank added the enhancement New feature or request label Sep 17, 2024
@frozenfrank frozenfrank self-assigned this Sep 17, 2024
@frozenfrank frozenfrank added important This has been deemed important by the professors for immediate attention and removed important This has been deemed important by the professors for immediate attention labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant