Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullstack: increase github verification failure feedback #453

Open
webecke opened this issue Oct 28, 2024 · 1 comment · May be fixed by #460
Open

Fullstack: increase github verification failure feedback #453

webecke opened this issue Oct 28, 2024 · 1 comment · May be fixed by #460
Labels
enhancement New feature or request future Requires availability of another feature first

Comments

@webecke
Copy link
Contributor

webecke commented Oct 28, 2024

When students fail the git commit verification, most of the time the "They don't have enough commits" message is enough. But when we get a "suspicious commit history" message, it would be nice to know which commits specifically are suspicious. I don't think we should show this info to the student, but we should show this to the TAs

@webecke webecke added the enhancement New feature or request label Oct 28, 2024
@frozenfrank
Copy link
Contributor

Note that much of this analysis is already being performed, it just isn't being passed all the way up the chain.

Preliminary work to support this feature is being done in #440. After that PR, we will still need to:

  • Pass the information up and include it in the Submission object.
  • Display the information on the UI in appropriate ways.

@frozenfrank frozenfrank added the future Requires availability of another feature first label Oct 28, 2024
@frozenfrank frozenfrank linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Requires availability of another feature first
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants