Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger not used correctly #326

Open
leonardocarreras opened this issue Nov 12, 2024 · 2 comments
Open

Logger not used correctly #326

leonardocarreras opened this issue Nov 12, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@leonardocarreras
Copy link
Collaborator

This needs fixing, using SPDLOG_LOGGER_INFO(

mSLog->info("\nCurrent reference phasor [I]: {:s}"

@leonardocarreras leonardocarreras added bug Something isn't working good first issue Good for newcomers labels Nov 12, 2024
@malikrohail
Copy link

can i fix this

@leonardocarreras
Copy link
Collaborator Author

leonardocarreras commented Nov 13, 2024

Hi! Thanks for your interest @malikrohail, would you mind then creating a PR in your own fork? Please remember to sign your commits to indicate that you adhere to the contribution guidelines .

You have examples of how to apply the required solution in the same file (this is for the DEBUG case, but is the same idea for INFO), for example

SPDLOG_LOGGER_DEBUG(mSLog, "\nUpdate current: {:s}",
Logger::matrixToString(**mIntfCurrent));

If you have questions, feel welcome to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants