Remove client-side cache for NFT images #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ngundotra
approved these changes
Aug 17, 2023
|
nice work guys! |
nicezic
added a commit
to gh-waybit/explorer
that referenced
this pull request
Aug 22, 2023
Remove client-side cache for NFT images (solana-labs#284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where some NFT images are not showing in Explorer
I think this is caused by a change in SWR affecting the
useCachedImagehook, since I bumped the version of SWR in #281But I don't think we need this caching layer on the client, we're only showing the image once and NFT images are (hopefully!) served by CDNs with their own appropriate caching behaviour. I don't think the indirection is giving us any benefit. So I've removed the
useCachedImagehook and we now just use the image URL directly to display the image. This resolves the issue because the image URLs themselves are working correctly.Links from the issue:
https://explorer-26hek7xby-solana-labs.vercel.app/address/6adQxeQ9BrakM4VnqwQnvfXRGFMt9M2JivJ3DVoWawGa
https://explorer-26hek7xby-solana-labs.vercel.app/address/BNqnMRoW6tTh9qn3q1XFe9ksf7bnX1s2GShdShuk7sZR/metadata?cluster=devnet
Fixes #283