Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete Sentry #292

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: delete Sentry #292

merged 1 commit into from
Sep 15, 2023

Conversation

steveluscher
Copy link
Collaborator

@steveluscher steveluscher commented Sep 15, 2023

chore: delete Sentry

Summary

One of the central tenets of measurement is this question: are you prepared to change what you work on based on the outcome of the data.

Explorer is not under the kind of active development that requires deep insights into runtime data at this time. Put another way, I personally have never performed work on the Explorer based on a result that I observed in Sentry.

Until this changes, let's get rid of it.

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 7:47pm

@steveluscher steveluscher mentioned this pull request Sep 15, 2023
steveluscher added a commit that referenced this pull request Sep 15, 2023
chore: format code

---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/solana-labs/explorer/pull/291).
* #292
* __->__ #291
# Summary

One of the central tenets of measurement is this question: are you prepared to change what you work on based on the outcome of the data.

Explorer is not under the kind of active development that requires deep insights into runtime data at this time. Put another way, I personally have never performed work on the Explorer based on a result that I observed in Sentry.

Until this changes, let's get rid of it.
@steveluscher steveluscher merged commit 15a5268 into master Sep 15, 2023
2 checks passed
@steveluscher steveluscher deleted the pr292 branch September 15, 2023 19:45
@steveluscher
Copy link
Collaborator Author

This seems to have taken first-load JS on the homepage from 217 kB to 171kB.

Lighthouse score is approaching 90%.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant