Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: File change breaks Prod if no hard refresh #1047

Closed
2 tasks done
MariuzM opened this issue Sep 4, 2023 · 2 comments
Closed
2 tasks done

[Bug?]: File change breaks Prod if no hard refresh #1047

MariuzM opened this issue Sep 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@MariuzM
Copy link

MariuzM commented Sep 4, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

I have Page1 and Page2 if i change something on Page2 and then using Page1 to navigate to Page2 i get error

error loading dynamically imported module: https://****/assets/about-52919eb7.js

I guess its due to the hash of the file name change but my current client session still working with V1 until i do hard refresh.

Is there any plan to work around this?

Expected behavior 🤔

Page2 should load without issue even if changes have been made and pushed to prod

@MariuzM MariuzM added the bug Something isn't working label Sep 4, 2023
@MariuzM MariuzM changed the title [Bug?]: [Bug?]: File change breaks Prod if no hard refresh Sep 4, 2023
@MariuzM
Copy link
Author

MariuzM commented Sep 4, 2023

Ive tested with Next.js it looks like its doing hard page refresh before continue fetching new components

@ryansolid
Copy link
Member

Hmm.. a client side navigation has no way of knowing it is out of date, except from the response.. and we fetch JS in parallel. Unless they have setup some background pinging of versioning I don't see how Next could ever know this. My understanding was that Vercel keeps previous deploys around. Its also possible I suppose that that fetch data before JS and in that case they could know, of course that would be very inefficient.

In any case this is an idea and if anyone has ideas on how to implement it we can consider making a request.

@solidjs solidjs locked and limited conversation to collaborators Dec 19, 2023
@ryansolid ryansolid converted this issue into discussion #1151 Dec 19, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants